Skip to content

Wrong event name in e-commerce spec #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shahin-hp opened this issue Oct 5, 2021 · 0 comments · Fixed by #1953
Closed

Wrong event name in e-commerce spec #1952

shahin-hp opened this issue Oct 5, 2021 · 0 comments · Fixed by #1953
Assignees
@markzegarelli
Labels
content When the bug is about content that needs to get fixed triaged

Comments

@shahin-hp
Copy link

What article on segment.com/docs is affected?

https://segment.com/docs/connections/spec/ecommerce/v2/

What part(s) of the article would you like to see updated?

Example snippet of Cart Shared event has wrong event name.

analytics.track('Cart Viewed', {
  share_via: 'email',
  share_message: 'Hey, check out this item',
  recipient: '[email protected]',
  cart_id: 'd92jd29jd92jd29j92d92jd',
  products: [
    { product_id: '507f1f77bcf86cd799439011' },
    { product_id: '505bd76785ebb509fc183733' }
  ]
});

Cart Viewed should be Cart Shared

Additional information

No response
@shahin-hp shahin-hp added content When the bug is about content that needs to get fixed triage labels Oct 5, 2021
@shahin-hp shahin-hp changed the title [Content]: Wrong event name in e-commerce spec Wrong event name in e-commerce spec Oct 5, 2021
@markzegarelli markzegarelli self-assigned this Oct 5, 2021
markzegarelli pushed a commit that referenced this issue Oct 5, 2021
updated Cart Shared snippet per #1952
81790e2
@markzegarelli markzegarelli mentioned this issue Oct 5, 2021
Merged
markzegarelli pushed a commit that referenced this issue Oct 5, 2021
Merge pull request #1953 from segmentio/1952_update-ecom-spec
0b03a46 
updated Cart Shared snippet per #1952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markzegarelli markzegarelli

Labels
content When the bug is about content that needs to get fixed triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated Cart Shared snippet per #1952 segmentio/segment-docs
2 participants
@markzegarelli @shahin-hp