Skip to content

Add clarity to HubSpot API limit #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

markzegarelli
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@markzegarelli markzegarelli requested a review from a team as a code owner January 31, 2022 21:39
@markzegarelli markzegarelli requested review from pwseg and removed request for a team January 31, 2022 21:39
@markzegarelli markzegarelli added the fixed-content fix to content that has outdated or wrong information label Feb 1, 2022
@markzegarelli markzegarelli merged commit e3da3a5 into develop Feb 1, 2022
@markzegarelli markzegarelli deleted the DOC-309_hubspot-api-request branch February 1, 2022 17:02
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request Feb 1, 2022
* Adding admonition infrastructure

* DOC-393 Taking it out of an admonition format and adding it to the paragraph above it

* [DOC-393] Simplifying the information, adding it to the sentence before it

* Fixes to Contributing page

* small update to ga4

* Update CONTRIBUTING.md

Frontmatter -> Front matter

* Add note about Criteo connection modes with Analytics.js (#2437)

* Add clarity to HubSpot API limit (#2436)

* Update CONTRIBUTING.md

* catalog update

* Add Troubleshooting section to GEC docs (#2434)

* add Troubleshooting section to GEC docs

* style edits

Co-authored-by: markzegarelli <[email protected]>

* redirect sprig actions (#2423)

* remove connection table

* Linking to FQL from Destination Filters doc (#2421)

* Linking to FQL from Destination Filters doc

* Update src/connections/destinations/destination-filters.md

Co-authored-by: stayseesong <[email protected]>

Co-authored-by: stayseesong <[email protected]>

* [byteplus] adding new destination folder in order to show new name in… (#2414)

* [byteplus] adding new destination folder in order to show new name in docs URL

* local links should be relative

Co-authored-by: markzegarelli <[email protected]>

* Add region unsupported message for all cloud sources (#2422)

* Add region unsupported message for all cloud sources

* Remove spaces

* prettify markdown

* copy edits

Co-authored-by: markzegarelli <[email protected]>

Co-authored-by: forstisabella <[email protected]>
Co-authored-by: pwseg <[email protected]>
Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: kdaswani <[email protected]>
Co-authored-by: rchinn-segment <[email protected]>
Co-authored-by: pwseg <[email protected]>
Co-authored-by: Niall Brennan <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: jinapark202 <[email protected]>
markzegarelli pushed a commit that referenced this pull request Feb 1, 2022
* Adding admonition infrastructure

* DOC-393 Taking it out of an admonition format and adding it to the paragraph above it

* [DOC-393] Simplifying the information, adding it to the sentence before it

* Fixes to Contributing page

* small update to ga4

* Update CONTRIBUTING.md

Frontmatter -> Front matter

* Add note about Criteo connection modes with Analytics.js (#2437)

* Add clarity to HubSpot API limit (#2436)

* Update CONTRIBUTING.md

* catalog update

* Add Troubleshooting section to GEC docs (#2434)

* add Troubleshooting section to GEC docs

* style edits

Co-authored-by: markzegarelli <[email protected]>

* redirect sprig actions (#2423)

* remove connection table

* Linking to FQL from Destination Filters doc (#2421)

* Linking to FQL from Destination Filters doc

* Update src/connections/destinations/destination-filters.md

Co-authored-by: stayseesong <[email protected]>

Co-authored-by: stayseesong <[email protected]>

* [byteplus] adding new destination folder in order to show new name in… (#2414)

* [byteplus] adding new destination folder in order to show new name in docs URL

* local links should be relative

Co-authored-by: markzegarelli <[email protected]>

* Add region unsupported message for all cloud sources (#2422)

* Add region unsupported message for all cloud sources

* Remove spaces

* prettify markdown

* copy edits

Co-authored-by: markzegarelli <[email protected]>

* Friendbuy cloud destination (#2416)

* Apply Friendbuy web destination documentation rename from master branch.

* Copy Friendbuy web destination documentation as basis for cloud destination.

* Update to Friendbuy web destination documentation.

* Documentation for new Friendbuy cloud destination.

* Apply suggestions from code review

Co-authored-by: rchinn-segment <[email protected]>

* Minor language tweaks.

* Changed "might" to "probably" because it's unlikely that someone using
  both Friendbuy and Segment wouldn't use the Friendbuy web destination.

* Changed "won't load" to "won't be loaded" because whether our JavaScript
  is loaded or not is outside of its control. Segment does not call the web
  destination's initialization function unless at least one mapping is
  enabled.

* Move the Friendbuy web destination documentation back to actions-friendbuy.

Co-authored-by: rchinn-segment <[email protected]>

* update catalog

Co-authored-by: forstisabella <[email protected]>
Co-authored-by: pwseg <[email protected]>
Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: kdaswani <[email protected]>
Co-authored-by: rchinn-segment <[email protected]>
Co-authored-by: pwseg <[email protected]>
Co-authored-by: Niall Brennan <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: jinapark202 <[email protected]>
Co-authored-by: David Hull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants