Create separate subcmds for get #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedannemann
commented
Sep 12, 2023
| @@ -38,109 +32,249 @@ type getCmdConfig struct { | |||
| var getConfig getCmdConfig | |||
|
|
|||
| func init() { | |||
| getCmd.Flags().BoolVar( | |||
| getCmd.PersistentFlags().BoolVar( | |||
There was a problem hiding this comment.
PersistentFlags allow us to pass these flags through from the parent command (get) to all the child commands
hhahn-tw
reviewed
Sep 12, 2023
This reverts commit 7b8ee42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make
topicctl getmore flexible in future work, this PR breaks thetopicctl getsubcommands into proper Cobra subcommands. This allows them to be configured individually and will open up the possibility of custom flags for each. The functionally of them is equivalent, but they now have descriptions.These commands are not under automated tests so I functionally tested several of them commands side by side with the old implementation and the output looked the same as before