Skip to content

Disambiguate exclude patterns to avoid upcoming warnings #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mjambon
Copy link
Member

@mjambon mjambon commented May 19, 2025

  1. Avoid upcoming warnings about unanchored patterns that will become anchored. These are paths.include and paths.exclude glob patterns containing a middle slash but not starting with ** or /.
  2. Ensure we preserve the current behavior when the implementation changes at the end of the deprecation period.

I already submitted a similar PR a few days ago (#3630) but it only took care of the includes. Since then, we've decided to emit a warning for all include and exclude patterns that will become anchored after a deprecation. This PR addresses excludes.

@mjambon mjambon requested review from kurt-r2c and LewisArdern May 19, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant