-
-
Notifications
You must be signed in to change notification settings - Fork 457
feat: add custom inputs for lambda name #283
feat: add custom inputs for lambda name #283
Conversation
This will be a great addition. I need to specify different environments (prod/stage) when deploying. Right now I'm deploying with a single |
@samstr check out the multiple-instance-environment examples in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks!
great feature! Thank you for making it happen! |
@Kampfheizung is this confirmed as working? Running V1.8.1 I still can't seem to set lambda names with or without the @serverless/template configuration, Is this reliant on this PR being merged at serverless-components/aws-lambda#16 ? |
@Podders I’ve not published the changes yet, will do tonight |
@danielcondemarin yeah I spotted its not published so I pulled it directly from github master and its still failing to set names for me I'm afraid, possibly my configuration but will test again with a clean project and 1.8.1 |
@danielcondemarin I tested again with the Next blog example app in a clean install, added serverless-next.js from github so that I have the current version of master which is 1.8.1, with
Added the following serverless.yml file
Ran
I'm pretty sure that this is reliant on serverless-components/aws-lambda#16 being merged for aws-lambda before it will work, the aws-lambda component itself ignores the |
@Podders yeah you are totally right - i already see that the PR is merged so it should be working now, correct? Thanks for your awesome help 🙌 |
@Kampfheizung I think it's still pending approval at serverless-components/aws-lambda, maybe @danielcondemarin could give them a nudge? pretty sure he's a contributor on that one :) |
Any progress on this? |
AFAIK the work in the next component is done. I'm waiting for serverless-components/aws-lambda#16 to be merged. |
Default name set to
this.context.resourceId()
by aws-lambda serverless component for both the SSR pages lambda and API lambda. To customise the name: