NO-ISSUE: Remove unnecessary GH workflows and fix sec advisories #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Zanini <[email protected]>
spolti
reviewed
Dec 20, 2024
| @@ -1,43 +0,0 @@ | |||
| # Copyright 2022 The Serverless Workflow Specification Authors | |||
There was a problem hiding this comment.
Not being used, the action is outdated, and GH keeps complaining about permissions. If you know which permissions to give to these pipelines, I can keep them.
There was a problem hiding this comment.
I didn't notice any issue related to permissions, I've compared it with another repository that uses this very same prow and the token permissions are the same.
But I have no strong opinion about removing and keeping it :)
/approve
There was a problem hiding this comment.
These permissions here:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token
Do you know which?
spolti
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
In this PR, we are removing a few workflows that are not being used anymore.
Special notes for reviewers:
There are a few security issues with these based on GH code scan.
Additional information (if needed):
If needed we can always bring prow commands back. Labeler wasn't working at all.