Skip to content

fix(*): remove key property of workflow #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(*): remove key property of workflow #756

wants to merge 1 commit into from

Conversation

lsytj0413
Copy link
Contributor

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification

Discussion or Issue link:

What this PR does / why we need it:

Fixed #742

Special notes for reviewers:

Additional information:

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@lsytj0413
Copy link
Contributor Author

/remove-stale

@github-actions github-actions bot removed the Stale PR label Apr 3, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cdavernas
Copy link
Member

@lsytj0413 Adding the blocked status because, as discussed in related issue, the key property is used to compute a runtime defined key of instances of the definition.
IMHO, removing the mutual exclusiveness of id and key should be the object of the PR, not the removal of a (personally) critical field

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment, please re-add the key property, or drop that PR altogether.
As a rule of thumb, you should first have the go ahead from maintainers in a discussion or issue before doing a PR, that would save you the time invested, which I however thank you for 🥰

@lsytj0413
Copy link
Contributor Author

/close

waiting for community's decision.

@lsytj0413 lsytj0413 closed this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow.id and workflow.key is duplicate
2 participants