Docs, code cleanup, and misc. fixes for smallvec #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrubeck
force-pushed
the
docs
branch
2 times, most recently
from
c0f6ad0 to
3ac0159
Compare
Ms2ger
approved these changes
Dec 5, 2016
| @@ -130,13 +150,45 @@ impl<A: Array> Drop for SmallVecData<A> { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| /// A Vec-like that can store a small number of elements inline. | |||
| @@ -245,6 +310,9 @@ impl<A: Array> SmallVec<A> { | |||
| } | |||
| } | |||
|
|
|||
| /// Reserve capacity for at least `additional` more elements to be inserted. | |||
| /// | |||
| /// May reserve more space to avoid frequent reallocations. | |||
There was a problem hiding this comment.
Maybe make a note about overflow behaviour. In particular, it is not safe to assume that you can actually fit additional new elements in it!
| if self.spilled() && self.capacity() > len { | ||
| if len <= self.inline_size() { | ||
| unsafe { | ||
| let (ptr, capacity) = match &self.data { |
|
@bors-servo r=Ms2ger
|
|
📌 Commit 7ca4463 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Dec 6, 2016
Docs, code cleanup, and misc. fixes for smallvec <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/40) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is