Skip to content

Read timeout does not been properly handled on Windows platform with TLS #269

Open
@sewenew

Description

@sewenew

On Windows platform, openssl returns SSL_ERROR_SYSCALL and set errno/WASGetLastError to 0 in case of read timeout. Check this issue for detail.

However, hiredis takes this as an error instead of timeout, and that results in redis-plus-plus' incorrect behavior, i.e. not properly handle timeout on Windows platform with TLS. Check this issue for detail.

I made a hot fix by modifying hiredis' code to properly handle this case. The modified version of hiredis can be found here. If you get this problem, you can install this modified version of hiredis.

However, I'm not sure if this is the best way to solve the problem. So I'll keep this issue open, and try to seek help from openssl and hiredis community.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions