Skip to content

Fixes to operator bundle #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

adambkaplan
Copy link
Member

Changes

  • Use shipwright- as name prefix in kustomization
  • Rename all manifests to use "operator" or use "operator-" prefix
  • Swap control-plane: controller-manager label with more specific
    app: shipwright-operator label.
  • Fix namespace rolebinding so that the operator is granted admin RBAC
    on namespaces.
  • Restore the categories, description, icon, and other information in
    the operator CSV.

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Bug fixes for operator bundle:

- Use `shipwright-` as name prefix in kustomization
- Rename all manifests to use "operator" or use "operator-" prefix
- Swap `control-plane: controller-manager` label with more specific `app: shipwright-operator` label.
- Fix namespace rolebinding so that the operator is granted admin RBAC on namespaces.
- Restore the categories, description, icon, and other information in the operator CSV.

- Use `shipwright-` as name prefix in kustomization
- Rename all manifests to use "operator" or use "operator-" prefix
- Swap `control-plane: controller-manager` label with more specific
  `app: shipwright-operator` label.
- Fix namespace rolebinding so that the operator is granted admin RBAC
  on namespaces.
- Restore the categories, description, icon, and other information in
  the operator CSV.
@openshift-ci openshift-ci bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels Nov 5, 2021
@openshift-ci openshift-ci bot requested review from imjasonh and zhangtbj November 5, 2021 18:45
@adambkaplan adambkaplan mentioned this pull request Nov 5, 2021
4 tasks
@gabemontero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@sbose78
Copy link
Member

sbose78 commented Nov 8, 2021

/lgtm

Copy link
Member Author

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Self-approving

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit d52c28b into shipwright-io:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants