Skip to content

Deploy Shipwright Build v0.9.0 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adambkaplan
Copy link
Member

Changes

  • Deploy Shipwright Build v0.9.0
  • Update version to release candidate.
  • Describe the fields in the ShipwrightBuild CRD.
  • Indicate which version of Shipwright Builds is installed.
  • Add installation instructions to the README.
  • Remove instruction that the target namespace needs to be created
    first.

Fixes #51

/kind feature
/kind documentation

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Deploy ShipwrightBuild v0.9.0 and improve installation documentation.

@openshift-ci openshift-ci bot added release-note kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. labels Apr 8, 2022
@adambkaplan adambkaplan force-pushed the update-operator-0.9.0 branch from 045b9d6 to 6664536 Compare April 8, 2022 16:22
@gabemontero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@adambkaplan adambkaplan mentioned this pull request Apr 8, 2022
4 tasks
- Deploy Shipwright Build v0.9.0
- Update version to release candidate
- Grant the operator the permissions needed to deploy Build's aggregate
user roles
- Describe the fields in the ShipwrightBuild CRD.
- Indicate which version of Shipwright Builds is installed.
- Add installation instructions to the README.
- Remove instruction that the target namespace needs to be created
  first.
@adambkaplan adambkaplan force-pushed the update-operator-0.9.0 branch from 6664536 to 5eaf09f Compare April 8, 2022 17:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@adambkaplan
Copy link
Member Author

e2e failed because the operator needs the same RBAC permissions as those granted to the new aggregated user roles.

@adambkaplan
Copy link
Member Author

/approve

Self-approving

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@gabemontero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@gabemontero
Copy link
Member

maybe mention the rbac addition in your PR description @adambkaplan

@openshift-merge-robot openshift-merge-robot merged commit 5555755 into shipwright-io:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator can create namespaces for ShipwrightBuild deployments
3 participants