Fix signing of released image #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0b91c10, the CSV stored in git was altered to include the `ko://` image reference. The real image reference is generated at build time, and its "resolved" CSV is stored in an ignored directory. This unfortunately broke the release GitHub action, which greps the in-tree CSV fo images to sign. This updates the release action to look at the "resolved" CSV in the `_output/olm` directory when searching for images to sign. This also updates cosign-installer to v2.3.0.
openshift-ci
bot
added
release-note
kind/bug
|
Note that upgrading the cosign installer version is necessary to get cosign v1.8.0, which is required to use the keyless signing mode. |
|
/approve self-approving |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In 0b91c10, the CSV stored in git was altered to include the
ko://image reference. The real image reference is generated at build time,
and its "resolved" CSV is stored in an ignored directory. This
unfortunately broke the release GitHub action, which greps the in-tree
CSV fo images to sign.
This updates the release action to look at the "resolved" CSV in the
_output/olmdirectory when searching for images to sign. This alsoupdates cosign-installer to v2.3.0.
/kind bug
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes