Skip to content

Update GitHub actions and Go to 1.19 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Aug 15, 2022

Changes

Updating GitHub actions like in shipwright-io/build#1085

Fixes #104

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 15, 2022
@openshift-ci openshift-ci bot requested review from imjasonh and otaviof August 15, 2022 19:16
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Sep 12, 2022
with:
go-version: 1.18.x
- uses: sigstore/[email protected]
go-version: ${{ matrix.go-version }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not needed, could you keep it at 1.18, or maybe move it to 1.19 together with #104

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@SaschaSchwarze0 SaschaSchwarze0 changed the title Update GitHub actions Update GitHub actions and Go to 1.19 Nov 16, 2022
@HeavyWombat HeavyWombat mentioned this pull request Jan 13, 2023
4 tasks
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
@SaschaSchwarze0
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HeavyWombat,SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 82394fe into shipwright-io:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump go modules and CI to go v1.19
4 participants