-
Notifications
You must be signed in to change notification settings - Fork 20
Use operator.tekton.dev/release label to detect Tekton version #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbe5cbb
to
78f42b5
Compare
As we reyling on label operator.tekton.dev/release on tektonconfigs crd to detect tekton operator version which has been added on 0.50.0 of tekton operator https://github.com/tektoncd/operator/releases/tag/v0.50.0 |
/assign @coreydaley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should make the needed values constants so that they can be updated in one place instead of having to hunt through the code or do a global search/replace for them.
Thoughts?
yes I agreen, done |
cf97654
to
d968ff7
Compare
/lgtm |
@jkhelil I do not have permissions to add the |
@coreydaley you seem to be in the approvers list https://github.com/shipwright-io/operator/blob/main/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
TektonOpMinSupportedVersion = "v0.50.0" | ||
TektonOpMinSupportedMajor = 0 | ||
TektonOpMinSupportedMinor = 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future - we can use the semver package to extract major/minor versions
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
https://issues.redhat.com/browse/BUILD-430
#61
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes