Skip to content

Use operator.tekton.dev/release label to detect Tekton version #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Sep 6, 2022

Changes

https://issues.redhat.com/browse/BUILD-430
#61

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

@jkhelil
Copy link
Contributor Author

jkhelil commented Aug 3, 2023

As we reyling on label operator.tekton.dev/release on tektonconfigs crd to detect tekton operator version which has been added on 0.50.0 of tekton operator https://github.com/tektoncd/operator/releases/tag/v0.50.0
I am also updating minimal tekton operator version required to 0.50.0

@jkhelil
Copy link
Contributor Author

jkhelil commented Aug 3, 2023

/assign @coreydaley
/assign @adambkaplan
Can you please review

Copy link
Contributor

@coreydaley coreydaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should make the needed values constants so that they can be updated in one place instead of having to hunt through the code or do a global search/replace for them.
Thoughts?

@jkhelil
Copy link
Contributor Author

jkhelil commented Aug 4, 2023

I think that we should make the needed values constants so that they can be updated in one place instead of having to hunt through the code or do a global search/replace for them.
Thoughts?

yes I agreen, done

@jkhelil jkhelil force-pushed the BUILD-430 branch 2 times, most recently from cf97654 to d968ff7 Compare August 4, 2023 08:37
@coreydaley
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@coreydaley
Copy link
Contributor

@jkhelil I do not have permissions to add the approved label.

@jkhelil
Copy link
Contributor Author

jkhelil commented Aug 4, 2023

@coreydaley you seem to be in the approvers list https://github.com/shipwright-io/operator/blob/main/OWNERS

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Comment on lines +4 to +6
TektonOpMinSupportedVersion = "v0.50.0"
TektonOpMinSupportedMajor = 0
TektonOpMinSupportedMinor = 50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future - we can use the semver package to extract major/minor versions

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit f607171 into shipwright-io:main Aug 4, 2023
@adambkaplan
Copy link
Member

@jkhelil has this addressed #61? If so, please close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants