SG-35165 Retry on URLError #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carlos-villavicencio-adsk
commented
May 22, 2024
carlos-villavicencio-adsk
commented
- Add retry only when encountering an URLError
- Adopt the existing strategy
- Add tests
carlos-villavicencio-adsk
requested review from
julien-lang and
eduardoChaucaGallegos
julien-lang
reviewed
May 22, 2024
| # response headers are in str(resp.info()).splitlines() | ||
| except urllib.error.URLError as e: | ||
| LOG.debug("Got a %s response. Waiting and retrying..." % e) | ||
| time.sleep(float(attempt) * self.BACKOFF) |
There was a problem hiding this comment.
The problem with this loop is that, in the worst case scenario, where every attempt failed, you end up sleeping before leaving the loop.
tests/test_client.py
Outdated
| @@ -449,7 +449,7 @@ def test_call_rpc(self): | |||
| self._mock_http(d, status=(504, "gateway timeout")) | |||
| self.assertRaises(api.ProtocolError, self.sg._call_rpc, "list", a) | |||
| self.assertEqual( | |||
| 4, | |||
| 3, | |||
There was a problem hiding this comment.
I standardize the number of retries to be reused on the library.
There was a problem hiding this comment.
Can you use self.sgMAX_ATTEMPTS instead or does it make sense to keep these 3 everywhere?
There was a problem hiding this comment.
I think it's feasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.