SG-35712 Prevent flaky disconnection when uploading thumbnails on publish #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
reviewed
Feb 11, 2025
| @@ -4330,13 +4330,13 @@ def connect(self): | |||
| ) | |||
|
|
|||
|
|
|||
| class CACertsHTTPSHandler(urllib.request.HTTPSHandler): | |||
| class CACertsHTTPSHandler(urllib.request.HTTPHandler): | |||
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
I don't have a clear answer for this. I was a trial/error change that made sense to me according to keep consistency on naming. Also, we're using SSL with TLS.
|
|
||
| attempt = 1 | ||
| while attempt <= self.MAX_ATTEMPTS: | ||
| # Perform the request | ||
| try: | ||
| opener = self._build_opener(FormPostHandler) |
There was a problem hiding this comment.
Side question: why don't we use httplib2 for those?
There was a problem hiding this comment.
I'm not sure how to answer this. This line was moved from outside the retry block, so in case it fails, the retry can start a new connection. I don't know the details of the original design.
eduardoChaucaGallegos
approved these changes
Feb 19, 2025
julien-lang
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a flaky disconnection when the publisher uploads the thumbnail. The most common errors are:
They seem to be related to TLS handshakes. While testing on local machines we consistently reproduced this with the following change: Move the connection opener to the retry block and change
CACertsHTTPSHandlerparent class.