SG-38301 App Session Launcher to use SHOTGUN_API_CACERTS just like python-api
#1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 79.79% 79.82% +0.02%
==========================================
Files 198 198
Lines 20760 20776 +16
==========================================
+ Hits 16566 16584 +18
+ Misses 4194 4192 -2 ☔ View full report in Codecov by Sentry. |
julien-lang
changed the title
SHOTGUN_API_CACERTS just like python-api
carlos-villavicencio-adsk
approved these changes
Feb 25, 2025
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
julien-lang
requested review from
bernie-laberge and
carlos-villavicencio-adsk
carlos-villavicencio-adsk
approved these changes
Feb 26, 2025
eduardoChaucaGallegos
approved these changes
Feb 26, 2025
julien-lang
deleted the
ticket/SG-38301-add-ca-cert-handle-app-session-launcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python API can use a custom CA Cert store using the
SHOTGUN_API_CACERTSvariablehttps://developers.shotgridsoftware.com/python-api/reference.html#shotgun-api-cacerts
App Session Launcher uses a different API and was using a different CA Cert store. It is now aligned with python-api (certifi).
Related to shotgunsoftware/python-api#373