Added LoadFileOrURLUsingReader #4159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krish Aryan <[email protected]>
|
@ramonpetgrave64 please review this |
|
This doesn't really fix the issue you've linked. it adds support for pulling from remote destinations but it still loads the entire blob into memory (because you're still passing around |
|
Yes but I am facing difficulty passing io.Reader in signature, err := static.NewSignature(blobBytes, sig, opts...). Can you give me a direction on how should I approach this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4112
Summary
Release Note
Added a new function that returns io.Reader instead of the entire message called LoadFileOrURLUsingReader
Documentation