Skip to content

Made naming rules more lax and migration script more stable. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Made naming rules more lax and migration script more stable. #70

merged 3 commits into from
Jun 19, 2018

Conversation

kodek16
Copy link
Member

@kodek16 kodek16 commented Jun 17, 2018

This PR includes a hotfix from Szkopuł production, a simple test, and a version bump.

@kodek16 kodek16 requested review from accek and radeusgd June 17, 2018 22:23
@codecov-io
Copy link

Codecov Report

Merging #70 into master will increase coverage by 2.17%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #70      +/-   ##
=========================================
+ Coverage   76.43%   78.6%   +2.17%     
=========================================
  Files          26      27       +1     
  Lines        2130    2183      +53     
=========================================
+ Hits         1628    1716      +88     
+ Misses        502     467      -35
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
filetracker/scripts/migrate_test.py 100% <100%> (ø)
filetracker/servers/base.py 61.33% <50%> (-1.34%) ⬇️
filetracker/scripts/migrate.py 92% <84.21%> (+92%) ⬆️
filetracker/servers/files.py 93.27% <0%> (-0.85%) ⬇️
filetracker/scripts/progress_bar.py 87.5% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac47e0...dd76a9f. Read the comment docs.

Copy link
Contributor

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd suggest adding one more test while you are at it.

_TEST_PORT_NUMBER = 45785


class MigrateScriptTest(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we've got tests for the migration script, maybe we could add a test that tries to upload a file with forbidden name and files to see if other files are migrated correctly in such a scenario?

@kodek16 kodek16 merged commit 359b474 into sio2project:master Jun 19, 2018
@kodek16 kodek16 deleted the migration-fix branch June 19, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants