Pass multiple visualElements

[Amerousful]

Have you read the documentation?

• Yes, I've read the how to make a reproducable bug guide
• Yes, I've read the how to debug my script guide

URL

https://imm-5257-form.com/

What are you trying to accomplish

Hello. I found an issue where only the latter passed value is accepted for flag --scriptInput.visualElements

---

Sitespeed verison: 35.7.5-plus1

What browser did you use?

Chrome

How to reproduce

Nutshell:

  --plugins.remove="@sitespeed.io/plugin-gpsi" \
  --plugins.remove="@sitespeed.io/plugin-lighthouse" \

---

Full command:

docker run --rm \
  --name sitespeed_test \
  -v "$(pwd):/sitespeed.io" \
  sitespeedio/sitespeed.io:35.7.5-plus1 \
  https://imm-5257-form.com/ \
  --n 1 \
  --plugins.remove="@sitespeed.io/plugin-gpsi" \
  --plugins.remove="@sitespeed.io/plugin-lighthouse" \
  --plugins.list \
  --visualElements \
  --scriptInput.visualElements="CustomReadiness_1:.cta-button" \
  --scriptInput.visualElements="CustomReadiness_2:.header-logo__name" \
  --filmstrip.showAll \
  --browsertime.videoParams.filmstripFullSize=true

Log output

None

[soulgalore]

Hi @Amerousful thank you for creating the issue. It seems like yargs handles input differently:

If you have a parameter like --test and add multiple ones, it automatically creates an array: --test 1 --test 2 becomes test: [1,2].

But if the key is like this: --a.test 1 --a.test 2 becomes a: { test: 2}.

For now I updated the documentation to recommend using a configuration file instead and then when I get the time I can check if I can make a PR to yargs.