Skip to content

Update go jose #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Update go jose #59

merged 3 commits into from
Apr 10, 2019

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Apr 5, 2019

Description

This PR adapts certificates code to [email protected], claims iat, nbf, and exp are now pointers instead of values.

This PR won't be merged until square/go-jose#224 gets merged. Instead of waiting for the merge we are using our fork.

Related to smallstep/cli#105

@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #59 into master will decrease coverage by 15.2%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
- Coverage   78.33%   63.12%   -15.21%     
===========================================
  Files          29       32        +3     
  Lines        2109     2644      +535     
===========================================
+ Hits         1652     1669       +17     
- Misses        337      854      +517     
- Partials      120      121        +1
Impacted Files Coverage Δ
authority/authorize.go 75% <0%> (ø) ⬆️
autocert/controller/client.go 0% <0%> (ø)
autocert/controller/main.go 4.38% <0%> (ø)
autocert/controller/provisioner.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85a083...b171e57. Read the comment docs.

@maraino maraino requested a review from dopey April 9, 2019 19:07
@maraino maraino marked this pull request as ready for review April 9, 2019 19:07
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just remember to revert cli branch in Gopkg.toml

@maraino maraino merged commit 27eddbf into master Apr 10, 2019
@maraino maraino deleted the update-go-jose branch April 10, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants