Adding Cors handler to http request handler in netty server #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhernandez35
reviewed
Jun 6, 2025
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
.../server-netty/src/main/java/software/amazon/smithy/java/server/netty/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Show resolved
Hide resolved
|
Thank you for the PR! |
Addign cors headers unit tests
rhernandez35
reviewed
Jun 6, 2025
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
.../server-netty/src/main/java/software/amazon/smithy/java/server/netty/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
rhernandez35
reviewed
Jun 7, 2025
server/server-core/src/main/java/software/amazon/smithy/java/server/core/CorsHeaders.java
Outdated
Show resolved
Hide resolved
rhernandez35
approved these changes
Jun 9, 2025
Comment on lines
53
to
54
| var corsTrait = job.operation().getApiOperation() | ||
| .service() |
There was a problem hiding this comment.
Suggested change
| var corsTrait = job.operation().getApiOperation() | |
| .service() | |
| var corsTrait = job.operation() | |
| .getApiOperation() | |
| .service() |
|
Can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #737
Description
Netty service
This PR contains a new handler to respond with require headers when smithy.api#cors trait is set in the service.
The CorsHandler supports the case of having multiple origins, when the origin value contains multiple origins separated by commas it will check against the origin in attached in the request.
Json Serializer Test fix.
The
testPrettyPrinting()test fails due to differences in line endings between operating systems. Windows uses \r\n (CRLF), while Unix-based systems (Linux/macOS) use \n (LF). The expected string, defined in a Java text block, contains Unix-style line endings (\n), but the actual output (result) contains Windows-style line endings (\r\n), causing the assertion to mismatch despite identical content. To ensure consistent behavior across platforms, we normalize line endings by removing \r before comparison or use System.lineSeparator() for OS-agnostic formatting.Test
No unit tests are configure for the netty-server subpackage. I manually tested from an external project and the requests returns the expected headers.