Pure python request pipeline #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
bb29685 to
3a6df83
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
2 times, most recently
from
ec58e87 to
1890159
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
1890159 to
0e83eeb
Compare
nateprewitt
reviewed
Apr 11, 2025
JordonPhillips
force-pushed
the
no-http-auth
branch
from
7ad2adf to
6f474c6
Compare
JordonPhillips
force-pushed
the
no-http-auth
branch
2 times, most recently
from
dbae11e to
6dbca91
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
0e83eeb to
5d189d2
Compare
JordonPhillips
force-pushed
the
no-http-auth
branch
from
75e5630 to
f00644a
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
2 times, most recently
from
aa96919 to
31a635c
Compare
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
31a635c to
6aa97b3
Compare
|
This is good to look at now. I'm working on the codegen changeover, which will bloat the pr size since so much is going to be deleted. I would prefer that to be a separate PR though. |
JordonPhillips
changed the title
nateprewitt
previously approved these changes
Jun 2, 2025
Comment on lines
+381
to
+384
| _LOGGER.debug("Calling endpoint resolver.") | ||
| endpoint: Endpoint = await call.endpoint_resolver.resolve_endpoint( | ||
| endpoint_params | ||
| ) |
There was a problem hiding this comment.
We should potentially be recording the endpoint_params here to inform how we got the result. I don't believe we have anything sensitive in those.
This replaces the code generated request pipeline with the hand-written one.
JordonPhillips
force-pushed
the
pure-python-request-pipeline
branch
from
6aa97b3 to
588c3f2
Compare
JordonPhillips
changed the base branch from
develop
to
replace-generated-request-pipeline
SamRemis
reviewed
Jun 3, 2025
| ) | ||
|
|
||
| _LOGGER.debug("Request to sign: %s", request_context.transport_request) | ||
| _LOGGER.debug("Signer properties: %s", option.signer_properties) |
There was a problem hiding this comment.
We need to merge signer properties with the properties from the option here. Something like this:
option.signer_properties = option.signer_properties scheme.signer_properties(context=request_context.properties)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the generated request pipeline with one that is hand-written. Look at all those removed lines!
Note that CI won't pass because we need quite a few fixes. I'm splitting those off so that this isn't too big, and I've changed the target branch to a feature branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.