Migrate to Github Action #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test action works fine, see https://github.com/snowplow-referer-parser/referer-parser/actions/runs/13809272172 |
|
publish_test_json action works fine, see https://github.com/snowplow-referer-parser/referer-parser/actions/runs/13810655374 |
oguzhanunlu
force-pushed
the
github-action
branch
2 times, most recently
from
db8123c to
3b2b379
Compare
oguzhanunlu
force-pushed
the
github-action
branch
from
137fe94 to
f7fa495
Compare
|
Another PR will follow to introduce test action |
istreeter
reviewed
Mar 13, 2025
Comment on lines
+16
to
+17
| - name: Check | ||
| run: cat referers.json |
There was a problem hiding this comment.
Please can you explain more how this github action works? I can see you cat the output file, but how does that create an asset which can be downloaded?
istreeter
reviewed
Mar 13, 2025
| @@ -90,6 +87,8 @@ You can contact the Snowplow Analytics team through any of the [channels listed | |||
|
|
|||
| [snowplow]: https://github.com/snowplow/snowplow | |||
|
|
|||
| [discourse]: https://discourse.snowplow.io | |||
There was a problem hiding this comment.
Discourse is moving to https://support.snowplow.io/hc/en-gb/community/topics/
istreeter
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @benjben 's excellent work at #226 with slight modifications.