Skip to content

Avoid duplicated connection event for default namespace. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2015
Merged

Avoid duplicated connection event for default namespace. #11

merged 1 commit into from
May 6, 2015

Conversation

jianjunz
Copy link
Contributor

@jianjunz jianjunz commented May 6, 2015

Fix #10.

melode11 added a commit that referenced this pull request May 6, 2015
@melode11
Merge pull request #11 from LittleLittle/connect
28d719a 
Avoid duplicated connection event for default namespace.
@melode11 melode11 merged commit 28d719a into socketio:master May 6, 2015
@melode11
Copy link
Contributor

melode11 commented May 6, 2015

I found a buggy case after merge:

  1. Connect the client first.
  2. Wait for a while.
  3. Access the default socket for the first time.

In this case, the connection timeout of the default socket will always be fired.

Already fixed here: 8ea0696

@jianjunz
Copy link
Contributor Author

jianjunz commented May 7, 2015

Thanks for fixing the bug.

@JinChengShi JinChengShi mentioned this pull request Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server side "connection" event triggered twice when a socket.io cpp client is connected
2 participants
@jianjunz @melode11