Skip to content

fix compatibility problem for gcc 4.8+. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2015
Merged

fix compatibility problem for gcc 4.8+. #24

merged 1 commit into from
Jun 12, 2015

Conversation

stefanhong
Copy link

I can't compile the code using gcc 4.8 nor gcc 4.9 on Linux without these fixes. The virtual destructor on message is straight forward, but I am not sure about the implication of removing const though. All test cases are passed. Also updated source files listed in README.md.

melode11 added a commit that referenced this pull request Jun 12, 2015
fix compatibility problem for gcc 4.8+.
@melode11 melode11 merged commit 9e9d76c into socketio:master Jun 12, 2015
@melode11
Copy link
Contributor

Thanks, your patch is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants