Skip to content

fix: updates for CentOS 7 support and feature #45 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2021
Merged

fix: updates for CentOS 7 support and feature #45 #271

merged 2 commits into from
Jan 15, 2021

Conversation

AdrianDC
Copy link
Contributor

Merge request for reference with the CentOS 7 compatibility fixes and rebased upon the #45 feature.

AdrianDC and others added 2 commits January 14, 2021 23:31
If CMake doesn't understand C++11-related property,
simply use the COMPILE_FLAGS property
@AdrianDC
Copy link
Contributor Author

AdrianDC commented Jan 14, 2021

@darrachequesne

Builds properly with this, used in production for a year :

docker run --rm -i -v "${PWD}:${PWD}" -w "${PWD}" centos:7.6.1810 <<EOF
yum install -y cmake gcc gcc-c++ make openssl-devel
cmake  ./
make install
EOF

@darrachequesne darrachequesne merged commit b196fa7 into socketio:master Jan 15, 2021
@darrachequesne
Copy link
Member

@AdrianDC thanks a lot for providing a way to reproduce the issue on CentOS 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants