Skip to content

fix hardcoded resource during uri construction #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix hardcoded resource during uri construction #28

wants to merge 1 commit into from

Conversation

antiqe
Copy link

@antiqe antiqe commented Jun 22, 2015

I corrected the resource that was hardcoded during the creation of the URI.

The connection should be :

sio::client h;
h.connect("http://127.0.0.1:3000/socket.io");

Or maybe define the resource "/socket.io" by default if it is not specified during the connect call.

@melode11
Copy link
Contributor

This can not be merged because it can not cover such case like:

sio::client h;
h.connect("http://127.0.0.1:3000");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants