fix: missing .get() in useDerivedValue mock
#6809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
approved these changes
Dec 12, 2024
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary In #6312 new API with `get`/`set` methods was added. However mock implementation wasn't updated and `useDerivedValue` still returns only `value`. This PR fixes this problem and returns getter as well. ## Test plan Run test that uses `.get()` on a value returned from `useDerivedValue`, Co-authored-by: Tomasz Żelawski <[email protected]>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary In #6312 new API with `get`/`set` methods was added. However mock implementation wasn't updated and `useDerivedValue` still returns only `value`. This PR fixes this problem and returns getter as well. ## Test plan Run test that uses `.get()` on a value returned from `useDerivedValue`, Co-authored-by: Tomasz Żelawski <[email protected]>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary In #6312 new API with `get`/`set` methods was added. However mock implementation wasn't updated and `useDerivedValue` still returns only `value`. This PR fixes this problem and returns getter as well. ## Test plan Run test that uses `.get()` on a value returned from `useDerivedValue`, Co-authored-by: Tomasz Żelawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6312 new API with
get/setmethods was added.However mock implementation wasn't updated and
useDerivedValuestill returns onlyvalue. This PR fixes this problem and returns getter as well.Test plan
Run test that uses
.get()on a value returned fromuseDerivedValue,