dbworker: Set additional columns in MarkCompleted/MarkErrored

[mrnugget]

It would be nice if it was possible to set additional columns when a record is MarkCompleted/MarkErrored.

For example: in campaigns we want to set the updated_at column every time a changeset has been updated.

That could also be done by

• Defining our own MarkCompleted/MarkErrored methods on a dbworker.Store shim
• Setting up a database trigger
• Defining a database view that does a max(updated_at, finished_at, started_at)
• ...

But maybe there's a more ergonomic way.

[efritz]

How many places do you call MarkCompleted/MarkErrored from in your campaigns reconciler? If they're only in a few places this could also be done with an additional update call, right? Are you worried about the expense of a second query in the update?

I know we talked about this online so maybe I'm forgetting some kind of minutiae.

[efritz]

Can you think of a reason you'd need this other than an updated_at field? Another solution here would be to just require that field on the worker records and we'll always update that column.

[mrnugget]

How many places do you call MarkCompleted/MarkErrored from in your campaigns reconciler? If they're only in a few places this could also be done with an additional update call, right? Are you worried about the expense of a second query in the update?

We don't call it right now, we use the default handler and set the failure_message to nil in our processor every time we update the record:

https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+FailureMessage+%3D+f:reconciler.go&patternType=regexp

Can you think of a reason you'd need this other than an updated_at field? Another solution here would be to just require that field on the worker records and we'll always update that column.

failure_message would be the other one. If it's completed, failure_message could be set to nil.

---

I don't think this is a huge issue, but I forgot to reset failure_message twice now and wanted to have some way to ensure that whenever a record is marked as successfully completed that failure_message is reset.