Skip to content

Allow multiple tags while filtering by tag #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitrisweb opened this issue Aug 28, 2015 · 5 comments
Closed

Allow multiple tags while filtering by tag #176

dmitrisweb opened this issue Aug 28, 2015 · 5 comments
Assignees

Comments

@dmitrisweb
Copy link

info.json has

{
  "title": "Module Name",
  "tag": [
    "myproject",
    "module",
    "universal"
  ]
}

This works:

<div class="source_col">
  <div class="source_catalog" data-nav="/items" data-tag="module">
    <h2 class="source_catalog_title">All Modules</h2>
  </div>
</div>

But filtering by multiple tags does not work (comma separated, nor space separated)

<div class="source_col">
  <div class="source_catalog" data-nav="/items" data-tag="module,universal">
    <h2 class="source_catalog_title">Universal Modules</h2>
  </div>
</div>
@robhrt7
Copy link
Member

robhrt7 commented Aug 28, 2015

Useful feature request, would be great is somebody of Backbase guys could help on getting this done in core.

@cheshirsky cheshirsky self-assigned this Aug 28, 2015
@cheshirsky
Copy link
Member

Implemented in navigation fixes branch.

@robhrt7
Copy link
Member

robhrt7 commented Aug 31, 2015

@dmitrisweb, what is the expected filter behaviour? Show specs that have both tags in the list, or 2 subsets? The current implementation by @cheshirsky checks specs that has both tags, which seems a bit wrong.

@robhrt7 robhrt7 reopened this Aug 31, 2015
@dmitrisweb
Copy link
Author

Spec should contain both tags to be displayed - that is correct
Like show only "Universal Modules" or show only "MyProject Modules"
filtering by 2 and more tags would be very helpful

@robhrt7
Copy link
Member

robhrt7 commented Sep 2, 2015

Ok, @cheshirsky almost finished the PR, I've done the review already. Feature will be included in 0.5.6 during this or next week.

@robhrt7 robhrt7 closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants