-
Notifications
You must be signed in to change notification settings - Fork 46
navigation-fixes: #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigation-fixes: #178
Conversation
cheshirsky
commented
Aug 28, 2015
- multiple tags support is added Allow multiple tags while filtering by tag #176
- templates extending ability Externalize templates for Catalogs #174
- specs validation is fixed pageLimit option does not work well for navigation which using tags filering #175
- multiple tags support is added; - templates extending ability; - specs validation is fixed;
Js Hint fails |
@@ -24,6 +24,7 @@ define([ | |||
"showPreviews": false, | |||
"sortType": "sortByDate", | |||
"sortDirection":"forward", | |||
"delimeter": " ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be comma by default. Could you please also add some info about this in generated nav documentation https://github.com/sourcejs/Source/blob/master/docs/data-nav/readme.md?
Do you use specs validation plugin in Backbase? |
Is this somehow related to external templates issue? #174 Could you please next time use more commits, so it would be easier to track specific changes? |
yes
Yes, for sure.
No, I don't think so.
Fixed. But checks are failed. By the way, I can't see any reasons or explanations. |
Now CasperJS tests are failing, seems like there's a JS error on the page in clean SourceJS set-up.
|
@@ -66,7 +66,7 @@ If there is no description, or you want to leave custom text, just use this extr | |||
|
|||
## Filtering by tag | |||
|
|||
As it's possible to define different tags for specs in `info.json` files (more in [docs](/docs/info-json/)), we can use them to filter custom navigation tree. | |||
As it's possible to define different tags for specs in `info.json` files (more in [docs](/docs/info-json/)), we can use them to filter custom navigation tree. It is also possible to define more than one tag for each spec. You can use "," as a delimeter, e.g. `templates,navigation`. Delimeter is also configurable (you can change it in `globalNav` options object). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mention about delimiter configuration, it's too much.
I can't see checking problems :( |
@@ -144,8 +149,11 @@ define([ | |||
* @returns {Boolean} true if spec shoud be skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct JSDom, first param is now not only a String, but could also be an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
generated navigation improvements