Skip to content

style(c): adopt cruby conventions #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

flavorjones
Copy link
Member

and some other conventions that we're using in Nokogiri.

@flavorjones flavorjones requested a review from tenderlove January 3, 2024 18:33
@flavorjones flavorjones mentioned this pull request Jan 3, 2024
19 tasks
Copy link
Member

@tenderlove tenderlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation on CRuby is a little different for switch statements. I'm not married to that style though. What are your thoughts?

@flavorjones flavorjones force-pushed the flavorjones-c-formatting branch from 1433fe9 to 08ca1c8 Compare January 3, 2024 22:08
and some other conventions
@flavorjones flavorjones force-pushed the flavorjones-c-formatting branch from 08ca1c8 to 895040f Compare January 3, 2024 22:10
@flavorjones flavorjones merged commit 870eecc into main Jan 3, 2024
@flavorjones flavorjones deleted the flavorjones-c-formatting branch January 3, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants