Fix tests for Python 3.12.7 #12993
Merged
Fix tests for Python 3.12.7 #12993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks good to me 👍
The Python3.13(-dev) test failures in CI seem to be due to the argparse feature landing in the dev branch (python/cpython#124436) -- that occurred after the 3.13.0 (final) release, so the conditional logic seems correct to me.
|
Yep, a bit of a mess to fix as I want to clearly distinguish commits but they're all interdependent... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12991