Ensures istio/istioctl is pulled locally prior to use #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
Merged
wind57
reviewed
Apr 12, 2024
| @@ -61,8 +61,6 @@ public final class Commons { | |||
| */ | |||
| public static final String ISTIO_VERSION = "1.16.0"; | |||
There was a problem hiding this comment.
yeah, I forgot to update this one... can you change it to 1.20.5 please? seems like its the highest version we can go to from my testing
There was a problem hiding this comment.
appears that version tends to use k8s x.28, so I'll update both
Signed-off-by: Adrian Cole <[email protected]>
wind57
reviewed
Apr 12, 2024
| @@ -72,7 +70,7 @@ private Commons() { | |||
| /** | |||
| * Rancher version to use for test-containers. | |||
| */ | |||
| public static final String RANCHER = "rancher/k3s:v1.25.4-k3s1"; | |||
| public static final String RANCHER = "rancher/k3s:v1.28.8+k3s1"; | |||
There was a problem hiding this comment.
typo here: rancher/k3s:v1.28.8-k3s1
Signed-off-by: Adrian Cole <[email protected]>
wind57
approved these changes
Apr 13, 2024
|
@ryanjbaxter Im ok with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1635 cc @wind57