Skip to content

Batch @RabbitListener Improvements #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Aug 4, 2022 · 0 comments · Fixed by #1490
Closed

Batch @RabbitListener Improvements #1489

garyrussell opened this issue Aug 4, 2022 · 0 comments · Fixed by #1490
Labels
type: enhancement
Milestone
3.0.0-M4

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Aug 4, 2022 •
edited
Loading

  • detect mis-configured listeners
  • widen accepted parameter types to Collection.
  • consumerBatchEnabled coerce batchListener to true
@garyrussell garyrussell added this to the 3.0.0-M4 milestone Aug 4, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 4, 2022
@garyrussell
spring-projectsGH-1489: Batch RabbitListener Improvements
1498963 
Resolves spring-projects#1489

- allow listeners to consume `Collection<?>` as well as `List<?>`
- detect a non-batch listener method in the batch adapter
- coerce `batchListener` to `true` when `consumerBatchEnabled` is true
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 4, 2022
@garyrussell
spring-projectsGH-1489: Batch RabbitListener Improvements
dfefecc 
Resolves spring-projects#1489

- allow listeners to consume `Collection<?>` as well as `List<?>`
- detect a non-batch listener method in the batch adapter
- coerce `batchListener` to `true` when `consumerBatchEnabled` is true
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 4, 2022
@garyrussell
spring-projectsGH-1489: Batch RabbitListener Improvements
85b11a2 
Resolves spring-projects#1489

- allow listeners to consume `Collection<?>` as well as `List<?>`
- detect a non-batch listener method in the batch adapter
- coerce `batchListener` to `true` when `consumerBatchEnabled` is true
@garyrussell garyrussell mentioned this issue Aug 4, 2022
Merged
artembilan pushed a commit that referenced this issue Aug 4, 2022
@garyrussell @artembilan
GH-1489: Batch RabbitListener Improvements
d96aa71 
Resolves #1489

- allow listeners to consume `Collection<?>` as well as `List<?>`
- detect a non-batch listener method in the batch adapter
- coerce `batchListener` to `true` when `consumerBatchEnabled` is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

GH-1489: Batch RabbitListener Improvements garyrussell/spring-amqp
1 participant
@garyrussell