`BeanCreationNotAllowedException` during shutdown

[mlichtblau]

In what version(s) of Spring AMQP are you seeing this issue?

3.1.7

Describe the bug

During shutdown of the application an exception is thrown.
I see the two expected log messages:

Mar 08 09:43:29.299
org.springframework.amqp.rabbit.listener.SimpleMessageListenerContainer
Waiting for workers to finish.

Mar 08 09:43:29.487
org.springframework.amqp.rabbit.listener.SimpleMessageListenerContainer
Successfully waited for workers to finish.

but aftewards I see this exception:

Mar 08 09:43:29.989
Exception in thread "rabbitListenerExecutor1" org.springframework.beans.factory.BeanCreationNotAllowedException: Error creating bean with name 'refreshEventListener': Singleton bean creation not allowed while singletons of this factory are in destruction (Do not request a bean from a BeanFactory in a destroy method implementation!)
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:220)
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:335)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:205)
at org.springframework.context.event.AbstractApplicationEventMulticaster.retrieveApplicationListeners(AbstractApplicationEventMulticaster.java:265)
at org.springframework.context.event.AbstractApplicationEventMulticaster.getApplicationListeners(AbstractApplicationEventMulticaster.java:222)
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:145)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:452)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:385)
at org.springframework.amqp.rabbit.listener.SimpleMessageListenerContainer$AsyncMessageProcessingConsumer.killOrRestart(SimpleMessageListenerContainer.java:1531)
at org.springframework.amqp.rabbit.listener.SimpleMessageListenerContainer$AsyncMessageProcessingConsumer.run(SimpleMessageListenerContainer.java:1408)

Sometimes I also see beans named startupTimeMetrics or delegatingApplicationListener that cannot be created during shutdown.

Is it intentional that during shutdown phase the events are still published?

To Reproduce

Not sure what exactly causes the issue now.

Expected behavior

No exception should be thrown during shutdown.

[artembilan]

Right, we should not emit event if the ApplicationContext:

	/**
	 * Return whether this context has been closed already, that is,
	 * whether {@link #close()} has been called on an active context
	 * in order to initiate its shutdown.
	 * <p>Note: This does not indicate whether context shutdown has completed.
	 * Use {@link #isActive()} for differentiating between those scenarios:
	 * a context becomes inactive once it has been fully shut down and the
	 * original {@code close()} call has returned.
	 * @since 6.2
	 */
	boolean isClosed();

This one we would use for current 4.0 and back-port to 3.2.x.
The 3.1.x branch is based on Spring Framework 6.1.x .
There we have to rely on the ContextClosedEvent instead.