GH-1459: Improve MeterRegistry Discovery #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
May 18, 2022
| throw new IllegalStateException("No micrometer registry present"); | ||
| } | ||
| Map<String, MeterRegistry> registries = context.getBeansOfType(MeterRegistry.class, false, false); | ||
| registries = filterRegistries(registries, context); |
There was a problem hiding this comment.
I wonder why does ObjectProvider.getIfUnique() not work for us here:
/**
* Return an instance (possibly shared or independent) of the object
* managed by this factory.
* @return an instance of the bean, or {@code null} if not available or
* not unique (i.e. multiple candidates found with none marked as primary)
* @throws BeansException in case of creation errors
* @see #getObject()
*/
@Nullable
T getIfUnique() throws BeansException;
?
There was a problem hiding this comment.
Where do we get one from?
There was a problem hiding this comment.
ApplicationContext.getBeanProvider(Class<T> requiredType)
There was a problem hiding this comment.
Oh, I didn't know about that; I've only seen them in the context of auto wiring. Cool.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1459
cherry-pick to 2.4.x