Skip to content

Update QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to use a custom prefix that isn't covered by the default #18285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

adiohana
Copy link

Updated QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to actually use a custom prefix (**) for comments.

This PR fixes gh-18275

aohana added 2 commits September 19, 2019 16:21
… to actually use a custom prefix which is not covered by the default: Fixes spring-projectsgh-18275
@wilkinsona
Copy link
Member

Thanks very much for the PR, @adiohana. That's pretty much exactly what I had in mind. In addition to the proposed changes, I think it should now be possible to delete the tables_h2.sql file as I believe it's now redundant. Would you like to update your PR to make that change too? No problem if not, we can take care of it (if it's needed) as part of merging this.

@wilkinsona wilkinsona added this to the 2.1.x milestone Sep 19, 2019
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 19, 2019
@adiohana
Copy link
Author

adiohana commented Sep 19, 2019

@wilkinsona updated the PR

@wilkinsona wilkinsona changed the title Quartz test Update QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to use a custom prefix that isn't covered by the default Sep 20, 2019
@adiohana
Copy link
Author

@wilkinsona ping for merging the PR :]

@philwebb
Copy link
Member

@adiohana We're all a bit tied up with the upcoming 2.2 RC1 release at the moment. There's no need to ping Andy as the issue has been assigned to the 2.1.x milestone so it shouldn't fall though the cracks. We'll hopefully get to it soon.

@wilkinsona
Copy link
Member

Thanks very much for making your first contribution to Spring Boot, @adiohana. The proposed changes have been merged into 2.1.x and forwards into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update QuartzDataSourceInitializerTests.commentPrefixCanBeCustomized to use a custom prefix that isn't covered by the default
4 participants