@RestControllerAdvice @ExceptionHandler Inconsistent behavior with @RestControllerEndpoint #31495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
philwebb
pushed a commit
that referenced
this pull request
Jun 22, 2022
Update `CompositeHandlerExceptionResolver` to search for beans in all contexts. Note that `BeanFactoryUtils.beansOfTypeIncludingAncestors` cannot not be used since we need to pick up all beans, even if they have the same name. See gh-31495
philwebb
added a commit
that referenced
this pull request
Jun 22, 2022
|
Thanks @terminux, this has now been merged to 2.6.x and forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I submitted this PR to solve #30899 based on @wilkinsona ’s comment.
When I switched to
BeanFactoryUtils.beansOfTypeIncludingAncestors, I found that still can't solve the problem, this is because the bean names oforg.springframework.boot.actuate.autoconfigure.web.servlet.CompositeHandlerExceptionResolverandorg.springframework.web.servlet.handler.HandlerExceptionResolverCompositeare the same.spring-boot/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/web/servlet/WebMvcEndpointChildContextConfiguration.java
Lines 100 to 101 in 837e2ac
So when using
BeanFactoryUtils.beansOfTypeIncludingAncestors,HandlerExceptionResolverCompositewill be overwritten byCompositeHandlerExceptionResolver.Maybe we need a variant of
BeanFactoryUtils.beansOfTypeIncludingAncestors, use collection to collectHandlerExceptionResolverinstead of map, or modify the bean name ofCompositeHandlerExceptionResolver, I chose the former for now.Closes gh-30899