Refactor BasicJsonParser to simplify JSON parsing logic #41876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
asashour
reviewed
Aug 16, 2024
...ng-boot-project/spring-boot/src/main/java/org/springframework/boot/json/BasicJsonParser.java
Show resolved
Hide resolved
hyunmin0317
force-pushed
the
refactor/basic-json-parser
branch
from
cfb5e01 to
11c86d2
Compare
mhalbritter
added
type: task
mhalbritter
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
Aug 21, 2024
mhalbritter
added a commit
that referenced
this pull request
Aug 21, 2024
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
BasicJsonParserclass to simplify the JSON parsing logic.The following changes are made:
trimLeadingCharacterandtrimTrailingCharactermethods into a singletrimEdgesmethod to reduce code duplication and improve clarity.parseNumbermethod to separate concerns and enhance maintainability.These changes aim to improve code readability and make future maintenance easier.
No functional changes are introduced.
Thank you for reviewing this pull request!