fix(docs): Fix broken links to testcontainers-junit-jupiter #45801
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marten Ringwelski <[email protected]>
maringuu
force-pushed
the
fix-broken-links
branch
from
8a14afc to
4b4b0b6
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for bringing this to our attention, @maringuu. The problem is broader than just the JUnit Jupiter extension as it affects classes in every module other than the core |
wilkinsona
added
status: declined
Thank you! While its not probable that I find the time soon I'll probably get back to this issue if it isn't closed yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated links were semi-broken. They did not point to where they shall point, but redirected to the docs startpage.
The build fails due to the following, so please dont start the CI yet :)
I am struggeling to find out where the version is picked up from.
Grepping for the other testcontainer url definitions did lead me to the anthora.yml which apparently picks the versions up from the version catalog.
However I struggle to find the catalog.
I'd be happy if a maintainer could point me to the right place or fixup the commit directly.
Thanks!