Skip to content

Spring Data Commons 3.3.4 breaks @ModelAttribute handling #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Mar 20, 2025 · 0 comments
Closed

Spring Data Commons 3.3.4 breaks @ModelAttribute handling #3258

sdeleuze opened this issue Mar 20, 2025 · 0 comments
Assignees
@mp911de @onobc
Labels
type: bug A general bug
Milestone
3.3.12 (2024.0.12)

Comments

@sdeleuze
Copy link
Contributor

As explored in #33791 and visible with a slightly modified version of the reproducer https://github.com/EnyaEnya/multipart-null, adding org.springframework.boot:spring-boot-starter-data-jpa to the project breaks @ModelAttribute handling as of Spring Boot 3.3.4, and I have been able to reproduce only by adding org.springframework.data:spring-data-commons:3.3.4 to the project.

The same project with org.springframework.data:spring-data-commons:3.3.3 or without Spring Data is fine.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2025
@sdeleuze sdeleuze mentioned this issue Mar 20, 2025
Closed
@mp911de mp911de self-assigned this Mar 20, 2025
onobc added a commit to onobc/spring-data-commons that referenced this issue Apr 24, 2025
@onobc
Avoid matching multipart parameters annotated with @ModelAttribute
50ed578 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
@onobc onobc mentioned this issue Apr 24, 2025
Closed
4 tasks
onobc added a commit to onobc/spring-data-commons that referenced this issue May 15, 2025
@onobc
Avoid matching multipart parameters annotated with @ModelAttribute
18ced24 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
onobc added a commit to onobc/spring-data-commons that referenced this issue May 15, 2025
@onobc
Allow @ProjectedPayload to be used on parameters.
b340597 
The `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
onobc added a commit to onobc/spring-data-commons that referenced this issue May 15, 2025
@onobc
Avoid matching multipart parameters annotated with @ModelAttribute
a2b6166 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
onobc added a commit to onobc/spring-data-commons that referenced this issue May 15, 2025
@onobc
Allow @ProjectedPayload to be used on parameters.
5467563 
The `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
onobc added a commit to onobc/spring-data-commons that referenced this issue May 15, 2025
@onobc
Allow @ProjectedPayload to be used on parameters.
54a85b9 
The `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 16, 2025
mp911de added a commit that referenced this issue May 16, 2025
@mp911de
Polishing.
ecfe77c 
Reformat code, refine Javadoc.

See #3258
Original pull request: #3277
mp911de pushed a commit that referenced this issue May 16, 2025
@onobc @mp911de
Avoid matching multipart parameters annotated with @ModelAttribute
4003964 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Also, the `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes #3258
Related tickets #2937
Original pull request: #3277

Signed-off-by: Chris Bono <[email protected]>
mp911de added a commit that referenced this issue May 16, 2025
@mp911de
Polishing.
a82abed 
Reformat code, refine Javadoc.

See #3258
Original pull request: #3277
mp911de pushed a commit that referenced this issue May 16, 2025
@onobc @mp911de
Avoid matching multipart parameters annotated with @ModelAttribute
5cae5cb 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Also, the `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes #3258
Related tickets #2937
Original pull request: #3277

Signed-off-by: Chris Bono <[email protected]>
mp911de added a commit that referenced this issue May 16, 2025
@mp911de
Polishing.
66eb8b7 
Reformat code, refine Javadoc.

See #3258
Original pull request: #3277
mp911de pushed a commit that referenced this issue May 16, 2025
@onobc @mp911de
Avoid matching multipart parameters annotated with @ModelAttribute
47abad4 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Also, the `@ProjectedPayload` annotation can now be used on parameters. This prepares for the upcoming removal of support for non-annotated projections.

Fixes #3258
Related tickets #2937
Original pull request: #3277

Signed-off-by: Chris Bono <[email protected]>
mp911de added a commit that referenced this issue May 16, 2025
@mp911de
Polishing.
07e8168 
Reformat code, refine Javadoc.

See #3258
Original pull request: #3277
@mp911de mp911de added this to the 3.3.12 (2024.0.12) milestone May 16, 2025
This was referenced May 27, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

@onobc onobc

Labels
type: bug A general bug
Projects
None yet
Milestone
3.3.12 (2024.0.12)
Development

Successfully merging a pull request may close this issue.

Avoid matching multipart parameters annotated with @ModelAttribute onobc/spring-data-commons
4 participants
@sdeleuze @mp911de @spring-projects-issues @onobc