Consider JTS geometry types as simple types. #1713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Jan 8, 2024
| @@ -58,6 +58,18 @@ public class PostgresDialect extends org.springframework.data.relational.core.di | |||
| "io.r2dbc.postgresql.codec.Polygon") // | |||
| .forEach(s -> ifClassPresent(s, simpleTypes::add)); | |||
|
|
|||
| // support the native JTS types supported by r2dbc-postgresql | |||
| Stream.of("org.locationtech.jts.geom.Geometry", // | |||
There was a problem hiding this comment.
It is sufficient to just add Geometry as the other types are subclasses and therefore considered simple types.
mp911de
added
type: enhancement
|
Thank you for your contribution. That's merged, polished, and backported now. |
|
Thanks for your work as maintainer! Great pointers and fast turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a quick PR that makes spring-data-r2dbc work with the native JTS types useful for work with PostGIS. These are natively supported in the r2dbc-postgresql driver and should be picked up automatically now if the JTS dependencies are installed.
See: #1711
I've tested this locally and found that it removes the need for at custom postgres dialect. No additional dependency on JTS is necessary.