DATAJDBC-637 - Time conversion now preserve nanosecond precision. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not.
mp911de
pushed a commit
that referenced
this pull request
Dec 8, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
mp911de
added a commit
that referenced
this pull request
Dec 8, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
mp911de
pushed a commit
that referenced
this pull request
Dec 8, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
mp911de
added a commit
that referenced
this pull request
Dec 8, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
mp911de
pushed a commit
that referenced
this pull request
Dec 8, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
mp911de
added a commit
that referenced
this pull request
Dec 8, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
|
That's merged, polished, and backported now. |
schauder
added a commit
that referenced
this pull request
Dec 10, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 10, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
schauder
added a commit
that referenced
this pull request
Dec 11, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Original pull request: #254.
schauder
added a commit
that referenced
this pull request
Dec 11, 2020
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*. New converters based converting to/from Timestamp are used. This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not. Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Make Jsr310TimestampBasedConverters package-private. Introduce convenience constructors to improve external configuration of JdbcCustomConversions. Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Original pull request: #254.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Original pull request: #254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard JSR 310 converters are no longer used for conversions between java.util.Date and java.time.*.
New converters based converting to/from Timestamp are used.
This preserves the precision because both the java.time.* API and Timestamp have nanosecond precision, while java.util.Date has not.
See DATAJDBC-637