Skip to content

Create Mqtt5 Example #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create Mqtt5 Example #364

wants to merge 1 commit into from

Conversation

nmy6452
Copy link

@nmy6452 nmy6452 commented May 29, 2025

This is the result of your work on Issue #323.

Signed-off-by: nmy6452 <[email protected]>
Copy link

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution. It is much appreciated!

@@ -0,0 +1,135 @@
/*
* Copyright 2016-2018 the original author or authors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all the copyright date for all .java files to 2025.

/**
* Starts the Spring Context and will initialize the Spring Integration message flow.
*
* @author nmy6452
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use your name if using the @author tag.

* @since 5.2
*
*/
public class BrokerRunning extends TestWatcher {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;

import org.junit.ClassRule;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update tests to use JUnit 5 . Thanks!


# Overview

This sample demonstrates basic functionality of the **Spring Integration MQTT Adapters**.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add your project to the list of available projects in the README for main sample project.

@@ -0,0 +1,392 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to add the pom.xml file. This will be done by the gradle tooling.

@cppwfs
Copy link

cppwfs commented May 30, 2025

I have to close this PR because a DCO requirement in that we can't use your handle for the acceptance of the DCO.
Can you push another PR with your name instead of your handle. Thank you!

You will notice I did add a few review comments, so if you can update the new PR with these changes that would be great!
Also you may want to us a branch when submitting your PR instead of main.

Again thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants