Skip to content

Migrate to JUnit 5 #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jzheaux opened this issue Mar 25, 2025 · 4 comments
Open

Migrate to JUnit 5 #1058

jzheaux opened this issue Mar 25, 2025 · 4 comments
Assignees
@etrandafir93
Labels
in: core type: enhancement
Milestone
3.3.x

Comments

@jzheaux
Copy link
Collaborator

jzheaux commented Mar 25, 2025

No description provided.

@jzheaux jzheaux added this to the 3.3.0-RC1 milestone Mar 25, 2025
@etrandafir93
Copy link
Contributor

hey @jzheaux, can i work on this one as well?

@jzheaux
Copy link
Collaborator Author

jzheaux commented Apr 17, 2025

Sure thing, @etrandafir93.

@jzheaux jzheaux modified the milestones: 3.3.0-RC1, 3.3.x Apr 17, 2025
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue Apr 29, 2025
@etrandafir93
Core module to JUnit5
fd87e6e 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
@etrandafir93
Copy link
Contributor

etrandafir93 commented Apr 29, 2025 •
edited
Loading

@jzheaux - we can use an openrewrite recipe for migrating to junit 5. I have already tried it locally, but it resulted in a lot of changes.
Should we do this module by module? If so, should I create separate PRs?

@jzheaux
Copy link
Collaborator Author

jzheaux commented May 7, 2025

Let's do a simple module first and see what the changes look like.

etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue May 10, 2025
@etrandafir93
test-support module to JUnit5
ca10190 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue May 10, 2025
@etrandafir93
formatting and fixes
8da35be 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue May 10, 2025
@etrandafir93
swap Assert imports
eb472b7 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue May 10, 2025
@etrandafir93
polish assertj assertions
987404f 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
etrandafir93 added a commit to etrandafir93/spring-ldap that referenced this issue May 10, 2025
@etrandafir93
cleanup
a42332e 
Issue spring-projects#1058

Signed-off-by: etrandafir93 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etrandafir93 etrandafir93

Labels
in: core type: enhancement
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
2 participants
@jzheaux @etrandafir93