Skip to content

Fixed debug log format strings #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,7 @@ public <T> T searchForObject(LdapQuery query, ContextMapper<T> mapper) {
@Override
public <T> T findByDn(Name dn, final Class<T> clazz) {
if (LOG.isDebugEnabled()) {
LOG.debug(String.format("Reading Entry at - %s$1", dn));
LOG.debug(String.format("Reading Entry at - %1$s", dn));
}

// Make sure the class is OK before doing the lookup
Expand All @@ -1703,7 +1703,7 @@ public T mapFromContext(Object ctx) throws javax.naming.NamingException {
throw new OdmException(String.format("Entry %1$s does not have the required objectclasses ", dn));
}
if (LOG.isDebugEnabled()) {
LOG.debug(String.format("Found entry - %s$1", result));
LOG.debug(String.format("Found entry - %1$s", result));
}

return result;
Expand All @@ -1717,7 +1717,7 @@ public void create(Object entry) {
Assert.notNull(entry, "Entry must not be null");

if (LOG.isDebugEnabled()) {
LOG.debug(String.format("Creating entry - %s$1", entry));
LOG.debug(String.format("Creating entry - %1$s", entry));
}

Name id = odm.getId(entry);
Expand All @@ -1741,7 +1741,7 @@ public void create(Object entry) {
public void update(Object entry) {
Assert.notNull(entry, "Entry must not be null");
if (LOG.isDebugEnabled()) {
LOG.debug(String.format("Updating entry - %s$1", entry));
LOG.debug(String.format("Updating entry - %1$s", entry));
}

Name originalId = odm.getId(entry);
Expand Down Expand Up @@ -1786,7 +1786,7 @@ public void update(Object entry) {
public void delete(Object entry) {
Assert.notNull(entry, "Entry must not be null");
if (LOG.isDebugEnabled()) {
LOG.debug(String.format("Deleting %s$1", entry));
LOG.debug(String.format("Deleting %1$s", entry));
}

Name id = odm.getId(entry);
Expand Down