Skip to content

Automatically enable TraceContext propagation in observability auto-configuration #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue May 23, 2024 · 0 comments
Closed

Automatically enable TraceContext propagation in observability auto-configuration #637

odrotbohm opened this issue May 23, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: observability Observability support type: improvement Minor improvements
Milestone
1.2

Comments

@odrotbohm
Copy link
Member

To make sure that spans resulting from asynchronous event handling being attached to the root trace causing the event publication in the first place, we should set up propagation of the TraceContext to the spawned threads.
@odrotbohm odrotbohm added in: observability Observability support type: improvement Minor improvements labels May 23, 2024
@odrotbohm odrotbohm added this to the 1.2 milestone May 23, 2024
@odrotbohm odrotbohm self-assigned this May 23, 2024
odrotbohm added a commit that referenced this issue May 23, 2024
@odrotbohm
GH-637 - Enable TraceContext propagation across asynchronous threads.
4e7dd5f 
We're now registering a ThreadPoolTaskScheduler and customize the resources created to propagate the Trace context into threads created by it. This is necessary to connect the tracing spans created for events handled asynchronously.
@odrotbohm odrotbohm mentioned this issue May 24, 2024
Closed
odrotbohm added a commit that referenced this issue May 24, 2024
@odrotbohm
GH-637 - Enable TraceContext propagation across asynchronous threads.
e1f8be0 
We're now registering a customizers for both the SimpleAsyncTaskExecutor (used for virtual threads) and the ThreadPoolTaskExecutor to register a ContextPropagatingTaskDecorator.
@odrotbohm odrotbohm mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: observability Observability support type: improvement Minor improvements
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@odrotbohm