Skip to content

Support transitive dependency lookup for ApplicationModules #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Sep 6, 2024 · 0 comments
Closed

Support transitive dependency lookup for ApplicationModules #802

odrotbohm opened this issue Sep 6, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: core Core module meta model type: improvement Minor improvements
Milestone
1.3 M3

Comments

@odrotbohm
Copy link
Member

Prerequisite for GH-31.
@odrotbohm odrotbohm added in: core Core module meta model type: improvement Minor improvements labels Sep 6, 2024
@odrotbohm odrotbohm added this to the 1.3 M3 milestone Sep 6, 2024
@odrotbohm odrotbohm self-assigned this Sep 6, 2024
odrotbohm added a commit that referenced this issue Sep 8, 2024
@odrotbohm
GH-802 - Allow transitive application module dependency resolution.
f09f3aa 
ApplicationModule now exposes both getDirectDependencies(…) and getAllDependencies(…), the former as alias for the now deprecated getDependencies(…) for symmetry reasons. The latter recursively resolves transitive dependencies.

We now optimize the dependency analysis by skipping types residing java and javax packages as they're not relevant to our dependency arrangement model. A few additional optimizations in ApplicationModuleDependencies to avoid iterating over each establishing dependency if all we need to look at is the general module dependency arrangement.

Improve performance of ApplicationModule.contains(…) checks by checking whether the given type can even live inside the package space of the module.
odrotbohm added a commit that referenced this issue Sep 8, 2024
@odrotbohm
GH-802 - Fix Javadoc.
0bbda9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core module meta model type: improvement Minor improvements
Projects
None yet
Milestone
1.3 M3
Development

No branches or pull requests
1 participant
@odrotbohm